-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build/use-setuptools-scm-for-versioning #52
Changes from all commits
49742e4
f5a5d2d
02bef79
79ede1a
c6bdb6d
10a79e2
1012c03
8c31339
d9b6f1c
d02cdfc
4a4d97f
6f6f082
25e491d
a16e500
a2bb38f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,13 +64,17 @@ Ready to contribute? Here's how to set up `napari-aicsimageio` for local develop | |
## Deploying | ||
|
||
A reminder for the maintainers on how to deploy. | ||
Make sure all your changes are committed. | ||
Then run: | ||
Make sure the main branch is checked out and all desired changes | ||
are merged. Then run: | ||
|
||
```bash | ||
$ bumpversion patch # possible: major / minor / patch | ||
$ git push | ||
$ git push --tags | ||
$ git tag -a "vX.Y.Z" -m "vX.Y.Z" | ||
$ git push upstream --follow-tags | ||
``` | ||
|
||
This will release a new package version on Git + GitHub and publish to PyPI. | ||
(The `-a` flag indicates an [annotated tag](https://git-scm.com/book/en/v2/Git-Basics-Tagging)) | ||
|
||
The presence of a tag starting with "v" will trigger the `publish` step in the | ||
main github workflow, which will build the package and upload it to PyPI. The | ||
version will be injected into the package metadata by | ||
[`setuptools-scm`](https://github.com/pypa/setuptools_scm) | ||
Comment on lines
+67
to
+80
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😍 I may add a |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,15 @@ | ||
# -*- coding: utf-8 -*- | ||
|
||
"""Top-level package for napari-aicsimageio.""" | ||
|
||
from importlib.metadata import PackageNotFoundError, version | ||
|
||
try: | ||
__version__ = version("napari-aicsimageio") | ||
except PackageNotFoundError: | ||
__version__ = "uninstalled" | ||
|
||
__author__ = "Eva Maxfield Brown" | ||
__email__ = "[email protected]" | ||
# Do not edit this string manually, always use bumpversion | ||
# Details in CONTRIBUTING.md | ||
__version__ = "0.7.1" | ||
|
||
|
||
def get_module_version() -> str: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you use this elsewhere? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do not. Happy to remove |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: will this just show the single tag that is being deployed or the whole taglist?