Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean unreferenced cached values of translations and configs #2510

Conversation

ntrotner
Copy link
Contributor

Proposed change

If translation or config is no longer subscribed to the value should be cleaned up

Related issues

@ntrotner ntrotner requested a review from a team as a code owner November 25, 2024 08:38
@ntrotner ntrotner changed the base branch from main to release/10.2 November 25, 2024 08:39
@ntrotner ntrotner changed the base branch from release/10.2 to main November 25, 2024 08:40
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.54%. Comparing base (c9fe500) to head (2d39d48).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ntrotner ntrotner marked this pull request as draft November 25, 2024 08:45
@ntrotner ntrotner marked this pull request as ready for review November 25, 2024 08:48
@fpaul-1A
Copy link
Contributor

you may want to change the target branch if you want the fix on release/11.4 or release/11.5.0-rc
if you target main, the fix will be available on 11.6

@ntrotner
Copy link
Contributor Author

ntrotner commented Nov 25, 2024

@fpaul-1A thx for the info, I've rebased it to 11.4

@ntrotner ntrotner changed the base branch from main to release/11.4 November 25, 2024 09:21
@ntrotner ntrotner force-pushed the fix/clean-cached-value-without-reference branch from 2d39d48 to 832d911 Compare November 25, 2024 09:26
@ntrotner ntrotner force-pushed the fix/clean-cached-value-without-reference branch from 832d911 to 376a06d Compare November 25, 2024 09:29
@kpanot kpanot merged commit 1f21bd9 into AmadeusITGroup:release/11.4 Nov 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: shareReplay keeps cached value in memory
3 participants