Update Travis-CI config to test macOS #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The review for inclusion into libstd pointed out we need to build (and preferably) run tests on all targets we support. This PR does not reach all the way currently, but it improves the situation by at least testing on macOS.
Also,
travis-cargoseems rather unmaintained, so I went ahead and re-wrote the Travis CI config according to how I usually do it for new crates. Any feedback and improvements suggestions are very welcome. One thing we could do is putting all thescriptstuff inside someci/travis.shfile in order to maybe slightly reduce duplication and repetition by using bash if statements.