Adopt windows-rs #311
Merged
Adopt windows-rs #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemenswasser
force-pushed
the
adopt-windows-rs
branch
from
bf79b74 to
1f94288
Compare
|
Several other crates also compile faster in the second compile. Are you sure this isn't the cpu changing frequency? |
It is deterministically faster. |
|
Thanks! |
|
Note that this might be an MSRV bump (at least when the |
15 tasks
MarijnS95
added a commit
to MarijnS95/imgui-rs
that referenced
this pull request
Mar 15, 2022
`parking_lot` now uses windows-rs's `windows-sys` crate, officially developed and vetted by Microsoft - the bindings are autogenerated from metadata and faster to compile too. See also Amanieu/parking_lot#311.
MarijnS95
added a commit
to MarijnS95/imgui-rs
that referenced
this pull request
Mar 15, 2022
`parking_lot` now uses windows-rs's `windows-sys` crate, officially developed and vetted by Microsoft - the bindings are autogenerated from metadata and faster to compile too. See also Amanieu/parking_lot#311.
dbr
added a commit
to imgui-rs/imgui-rs
that referenced
this pull request
Mar 19, 2022
`parking_lot` now uses windows-rs's `windows-sys` crate, officially developed and vetted by Microsoft - the bindings are autogenerated from metadata and faster to compile too. See also Amanieu/parking_lot#311.
ctrlcctrlv
pushed a commit
to MFEK/imgui.rlib
that referenced
this pull request
Sep 24, 2022
`parking_lot` now uses windows-rs's `windows-sys` crate, officially developed and vetted by Microsoft - the bindings are autogenerated from metadata and faster to compile too. See also Amanieu/parking_lot#311.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change from using the unofficial winapi bindings, to using the official windows bindings from Microsoft.
I have also a PR open at winit: rust-windowing/winit#2057
They suggested that parking_lot (dependency of winit) should also be switched over to windows-rs.
For this port I am using the more lightweight and lower level windows-sys (which is closer to winapi).
For me build times are faster with windows-rs 🎉
Before(winapi 1.19s, total time 2.2s):
After(windows-sys 0.94s, total time 1.7s):