Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow content to visually extrude from a Spotlight #1263

Closed
wants to merge 11 commits into from
Closed

feat: Allow content to visually extrude from a Spotlight #1263

wants to merge 11 commits into from

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Jun 17, 2024 •
edited
Loading

This draft is a PoC for the usage of CSS gradients to allow the content to extrude.

@github-actions github-actions bot temporarily deployed to demo-DES-802-spotlight-duotone June 17, 2024 11:21 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-802-spotlight-duotone June 17, 2024 11:23 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-802-spotlight-duotone June 17, 2024 11:25 Destroyed
@dlnr dlnr self-assigned this Jun 17, 2024
@VincentSmedinga VincentSmedinga changed the title feat: Spotlight extruding content feat: Allow content to visually extrude from a Spotlight Jun 19, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-802-spotlight-duotone June 21, 2024 13:51 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-802-spotlight-duotone June 26, 2024 09:32 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-802-spotlight-duotone June 27, 2024 12:55 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-802-spotlight-duotone June 28, 2024 12:28 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-802-spotlight-duotone July 2, 2024 21:27 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-802-spotlight-duotone July 2, 2024 21:34 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-802-spotlight-duotone July 3, 2024 09:22 Destroyed
@VincentSmedinga
Copy link
Contributor

Thanks for this effort. We’re closing it in favour of #1397.

  • The use of gradients makes the height of the Spotlight unrelated to that of the text.
  • The dependency on the Aspect Ratio component makes it less broadly applicable.
  • The feature of spanning rows in the Grid has proved useful.

@VincentSmedinga VincentSmedinga deleted the feature/DES-802-spotlight-duotone branch September 12, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dlnr dlnr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlnr @VincentSmedinga