feat: Add utility functions as methods to Dialog #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-946-add-util-functions-to-dialog
RubenSibon
previously approved these changes
Sep 10, 2024
github-actions
bot
temporarily deployed
to
demo-DES-946-add-util-functions-to-dialog
github-actions
bot
temporarily deployed
to
demo-DES-946-add-util-functions-to-dialog
VincentSmedinga
approved these changes
Sep 11, 2024
VincentSmedinga
deleted the
feature/DES-946-add-util-functions-to-dialog
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
It adds the
closeDialogandopenDialogutility functions as methods toDialog.Why
Less exports and a more contained component.
How
Similar to how we do subcomponents, using
Object.assign.Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary: