Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Sort imports and exports in index files of Sass and React #1796

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

This adds ./ before the path of all Sass @use rules where that’s missing.

Then I couldn’t help myself and sort the Sass imports, and then I did the React exports as well. We’ll need to resolve some conflicts in our current PRs, but not many and they are simple.

Why

Not sure if the relative imports are more robust now, but they are more consistent. And sorting things is fun.

How

N/A

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • None

@alimpens
Copy link
Contributor

alimpens commented Dec 20, 2024

Fun fact :D I prefer the imports the way they were, seeing as Sass documents this behaviour explicitly.

@alimpens alimpens mentioned this pull request Dec 20, 2024
5 tasks
@github-actions github-actions bot temporarily deployed to demo-sass-use-relative-paths December 20, 2024 10:18 Destroyed
@VincentSmedinga VincentSmedinga changed the title chore: Use relative paths in Sass imports; sort imports and exports chore: Sort imports and exports in index files of Sass and React Dec 20, 2024
@github-actions github-actions bot temporarily deployed to demo-sass-use-relative-paths December 20, 2024 10:24 Destroyed
@github-actions github-actions bot temporarily deployed to demo-sass-use-relative-paths December 20, 2024 10:37 Destroyed
@alimpens alimpens merged commit 122d15b into develop Dec 20, 2024
6 checks passed
@alimpens alimpens deleted the chore/sass-use-relative-paths branch December 20, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants