feat: Let Footer set its own background colour #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove the blue option from Spotlight, which should not be used.
5 tasks
alimpens
reviewed
Dec 20, 2024
| - The Footer is the same on every page of the application. | ||
| - For applications, only the Page Menu can be sufficient. |
There was a problem hiding this comment.
By describing it like this, it's easy to mess up the semantics. We currently do this in the Amopis prototype, the Page Menu isn't wrapped in a footer.
A bit of a side note, but: I made a ticket to incorporate the PageMenu in Footer, that should help with this.
There was a problem hiding this comment.
This line was only moved. Should we clarify the docs now or when we pick up the tickets you mentioned?
There was a problem hiding this comment.
Maybe we should do it now, to hopefully prevent people from making this mistake.
github-actions
bot
temporarily deployed
to
demo-DES-1113-remove-spotlight-from-footer
# Conflicts: # packages/css/src/components/index.scss
github-actions
bot
temporarily deployed
to
demo-DES-1113-remove-spotlight-from-footer
alimpens
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove the blue option from Spotlight, which should not be used.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
The top section of the Footer now sets its background colour through a new token and a new style declaration.
Why
This prepares for the removal of the blue option of Spotlight.
We want to prevent a blue Spotlight being used elsewhere on the page.
How
Replaced Spotlight with a div, added a token, updated documentation, etc.
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes