fix(Avatar): Remove incorrect aspect ratio for image #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSmedinga
changed the title
alimpens
reviewed
Jan 22, 2025
We don’t need the base styles of our Image component. All the aspect ratio stuff in there is irrelevant, because we reset it here. The phantom whitespace thing is not an issue, because this image is a child of a wrapper with an aspect ratio. And the alt text of this image is an empty string.
github-actions
bot
temporarily deployed
to
demo-avatar-image-aspect-ratio
VincentSmedinga
changed the title
alimpens
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
Restores the correct display of an Image in an Avatar.
Why
The new default aspect ratio for the Image component (introduced in #1593) forces it to 16:9.
How
I’m resetting the aspect ratio for an
.ams-imagein an.ams-avatar. We don’t know its dimensions, and the user can’t easily provide them. We already ensured to show the center of the image; I’ve made that explicit in the docs.I decided against using a clean HTML
imgelement because we still want to apply the other base styles of our image component.Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes
None.