Drop icon changing for the .desktop file and remove superfluous icons/states #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trigg Seems like I can add you as a reviewer but can you take a look at this? 👼 |
Antiz96
commented
May 7, 2024
Antiz96
force-pushed
the
drop_icon_changing
branch
from
c21eab5 to
0c619d2
Compare
trigg
reviewed
May 7, 2024
|
No material complaints from me, I can't crash it and it continues to install as expected |
Cool, thanks a lot for the review! Merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way this "dynamic icon changes" in the
.desktopfile has been initially implemented on Arch-Update's side has always been hacky and do not even work properly for most people (as most panel/taskbar/dock do not support real time refreshing icons anyway).There's a work in progress to handle that properly in systray applet (see #146).
This PR also removes the superfluous "checking" and "installing" icons/states. I guess we're only interested to know if we're up to date or if there are updates available.
Addresses parts of #146