Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinning wheel in UI Config #92

Open
Seexelas opened this issue Jan 24, 2022 · 56 comments
Open

Spinning wheel in UI Config #92

Seexelas opened this issue Jan 24, 2022 · 56 comments
Assignees
Labels

Comments

@Seexelas
Copy link

Describe your issue

I did a fresh install of my Rasp. Homebridge, I installed the Vieramatic plugin, when installed, I get the web ui config page but with a never ending spinning wheel.

Issue Context

Please add the following items, when applicable:

  • Homebridge 1.4.0
  • Node.js Version | v16.13.2
  • Npm Version | v8.3.1

Regular logs show's nothing.

2022-01-24 16_18_06-Homebridge - Personal - Microsoft​ Edge

Tried on Chrome and Edge.

I just restarted the whole Rasp, nothing's change.

Here is the debug on Chrome :

2022-01-24 16_23_26-Settings

I also tried on my iPhone on Safari, same result.

Thanks for the help,

Best regards ,

Alexis

@Seexelas
Copy link
Author

OK, so I used my backup of my config.json, get the part for my Panasonic Tv in the current config.json. restarted and there the web ui is working good.

@AntonioMeireles
Copy link
Owner

@Seexelas

welcome back!

hummm

On one hand glad it is sorted. On the other... shouldn't happen.

what TV model do you have ?

thanks in advance!

@Seexelas
Copy link
Author

Hi Antonio,

Thanks ;) Hope everything's good for you.

I have the Panasonic 65GZ2000

@AntonioMeireles
Copy link
Owner

did you got anything relevant in the "Console" tab in Chromes's debug ?

@AntonioMeireles
Copy link
Owner

[will try to find a way to reproduce and will get back to you]

@Seexelas
Copy link
Author

Not so far, it stays that way.

Is there a discovery or something the first time ?

@AntonioMeireles
Copy link
Owner

there was. it's disabled - breaks docker setups. still looking at how to get it properly done for all.
i suspect that i 've got some regression - regarding clean installs / empty setups at 1st install. but need to try to repro when at home with some spare time.

@Seexelas
Copy link
Author

I have a docker image for test, do you want me to test it also there ?

@AntonioMeireles
Copy link
Owner

let's fix this specific issue 1st :-) then will bug you with docker ;-)

AntonioMeireles added a commit that referenced this issue Jan 24, 2022
when we install this plugin for first time (and nothing exists in
homebridge's config file) homebridge.getPluginConfig() returns undefined
when called by the UI, which wasn't accounted for and broke our custom
UI.

This should now be fixed i.e. an end-user should be able to fully
setup a TV strictly via our UI and without ever having to resort to
manually edit homebridge's config.

Signed-off-by: António Meireles <[email protected]>
@AntonioMeireles
Copy link
Owner

@Seexelas

confirm please that [email protected] that i've just published fixes this issue.

@AntonioMeireles AntonioMeireles added bug Something isn't working and removed something may be wrong not sure yet labels Jan 24, 2022
@Seexelas
Copy link
Author

Hi Antonio,

I did a full uninstall, and a config.json cleanup. Rebooted my rasp, installed your plugin.

Same result, spinning wheel.

@AntonioMeireles
Copy link
Owner

@Seexelas

thanks for reporting. That's unexpected. can you attach your 'cleaned' config.json ? also, what timezone are you on ?
(i'm only will be able to look at this again in around 11hrs)

@Seexelas
Copy link
Author

Seexelas commented Jan 25, 2022

You will find enclosed the config.json that is actually working (without your plugin as it is uninstalled).

I'm from Luxembourg, so I have right now 11:29 am.

Thanks for your help.

@Seexelas
Copy link
Author

config (1).txt

@AntonioMeireles
Copy link
Owner

OK. will get back to you after yours' 9pm. thanks!

@AntonioMeireles
Copy link
Owner

@Seexelas can you give a quick test to [email protected] (went just out), please ?

AntonioMeireles added a commit that referenced this issue Jan 25, 2022
- en passant refactored how PluginConfig is being handled internaly

Signed-off-by: António Meireles <[email protected]>
@Seexelas
Copy link
Author

Hi Antonio,

Still the same :S

I switch to debut mode :S but nothing shows up

@AntonioMeireles
Copy link
Owner

AntonioMeireles commented Jan 25, 2022

@Seexelas

plz install a debug version - npm i -g homebridge-vieramatic@debug, and restart homebridge.
then please attach here the contents from the "Console" tab in Chromes's debug - you should get lines starting by (updateGlobalConfig) --> there...

@Seexelas
Copy link
Author

Seexelas commented Jan 25, 2022

I have this :

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'tvs')
    at J4 (VieraConfigUI.tsx:23:7)
    at async VieraConfigUI.tsx:70:24
J4 @ VieraConfigUI.tsx:23
await in J4 (async)
(anonymous) @ VieraConfigUI.tsx:70
n9 @ VieraConfigUI.tsx:67
i9 @ VieraConfigUI.tsx:69
p8 @ index.js:506
U2 @ index.js:173
l6 @ children.js:124
u8 @ index.js:392
U2 @ index.js:226
l6 @ children.js:124
U2 @ index.js:196
l6 @ children.js:124
U2 @ index.js:196
l6 @ children.js:124
U2 @ index.js:196
M @ render.js:16
R1 @ render.js:55
(anonymous) @ VieraConfigUI.tsx:335
_handleIncomingMessage @ ui.ts:70
postMessage (async)
confirmReady @ main-es2015.9d482d945810494ac85a.js:1
handleMessage @ main-es2015.9d482d945810494ac85a.js:1
invokeTask @ polyfills-es2015.e8bb8be2ebc926cac2d0.js:1
onInvokeTask @ main-es2015.9d482d945810494ac85a.js:1
invokeTask @ polyfills-es2015.e8bb8be2ebc926cac2d0.js:1
runTask @ polyfills-es2015.e8bb8be2ebc926cac2d0.js:1
invokeTask @ polyfills-es2015.e8bb8be2ebc926cac2d0.js:1
p @ polyfills-es2015.e8bb8be2ebc926cac2d0.js:1
f @ polyfills-es2015.e8bb8be2ebc926cac2d0.js:1
postMessage (async)
(anonymous) @ index.html?origin=http%3A%2F%2F192.168.1.250&v=4.0.22-debug1:17
load (async)
(anonymous) @ index.html?origin=http%3A%2F%2F192.168.1.250&v=4.0.22-debug1:16

@AntonioMeireles
Copy link
Owner

trying to understand why i do not get that error here...

@Seexelas
Copy link
Author

I tried edge, chrome, safari on my phone and it's the same !

When I put the configuration of my tv back in config.json and restart. No more error in Chrome console and it works.

@Seexelas
Copy link
Author

Seexelas commented Jan 25, 2022

Hummm...

So with the web ui working, I switched to edit mode, delete my tv configuration, restarted and there it is working.

Even with a full restart of the rasp, it still working !

@AntonioMeireles
Copy link
Owner

this is bizarre. it works here (on the mac) on both firefox, safari, edge and chrome. and in safari in the iphone.

image

@AntonioMeireles
Copy link
Owner

(wondering) did you did an hard refresh on the browser of the UI ? i suspect that perhaps the UI may had gone nuts between homebridge updates (as server (hb) side code changed but UI one not fully... (just thinking loud)

@AntonioMeireles
Copy link
Owner

@Seexelas

(morning!) what IOS / safari version are you testing on ?

@Seexelas
Copy link
Author

Morning :)

IOS 15.3 RC.

I will try with a fresh install of Chrome on my iPhone and let you know.

@AntonioMeireles
Copy link
Owner

AntonioMeireles commented Jan 26, 2022

humm... betas don't count :-) . OTOH that should go public this week or early next one. still digging. (&& thanks again)

@Seexelas
Copy link
Author

So Chrome on IOS is working.

Incognito mode on PC Chrome and Edge -> Working.

I tried removing my Adblock, but the same result.

@AntonioMeireles
Copy link
Owner

ok, so what's not working ?
safari on IOS/RC and what else ?

@Seexelas
Copy link
Author

Chrome / Edge normal mode
Safari IOS

@AntonioMeireles
Copy link
Owner

AntonioMeireles commented Jan 26, 2022

Chrome / Edge work here in MacOS (plain Monterey) . can you try to disable / bissect extensions to see which one is b0rking things ?

@Seexelas
Copy link
Author

I have an another PC with a fresh install. I will try on this one and let you know. Also same with the phone, I will try on my work phone.

@Seexelas
Copy link
Author

Sooooooooooooooo...

Work phone (iOS 15.2.1) -> Safari ok
My other laptop (Windows 10) with Chrome and Adblock -> ok on Chrome.

It's driving me crazy

@AntonioMeireles
Copy link
Owner

@Seexelas

hi again! did you made any progresses on this ? here even with latest MacOS and IOS iterations (that went public last night) things keep behaving ...

thanks in advance

@AntonioMeireles AntonioMeireles added something may be wrong not sure yet and removed bug Something isn't working labels Jan 27, 2022
@Seexelas
Copy link
Author

Hi Antonio,

I did a lot of test, I don't know, I really don't know.

I added my Tv manually for now, I don't know what to test more

@AntonioMeireles
Copy link
Owner

@Seexelas

but are you still hitting the original issue or not ?

@Seexelas
Copy link
Author

Yes.

Last results were :

  • MacOS (last update) -> Safari, Chrome OK
  • iOS Personnal -> 15.3 RC -> Nok Safari, Chrome ok
  • Work phone (iOS 15.2.1) -> Safari ok
  • Work laptop -> Win11 -> Edge, Chrome -> Nok
  • Home laptop -> WIn10 -> Chrome, Edge ok

If I input my configuration into config.json, I don't have anymore issue with the webui (and if I delete the Tv Config by the plugin webui, after restart, it works).

It's when I delete the whole plugin and configuration, than restart and the problem comes back.

@AntonioMeireles
Copy link
Owner

on your iPhone, when with spare time, check plz if issue remains after the update to 15.3 final.
still digging.

and thanks again!

@Seexelas
Copy link
Author

Hi Antonio.

I just did it, and it's the same.

@AntonioMeireles
Copy link
Owner

@Seexelas

when you have time take a look at [email protected].

have a great weekend && thanks!

@Seexelas
Copy link
Author

Hi Antonio,

Sadly it is still the same

thanks

@Seexelas
Copy link
Author

Seexelas commented Feb 4, 2022

Hi Antonio,

I saw that you put a new version, should I try it ? Or no corrections for my issue ?

Many thanks

@AntonioMeireles
Copy link
Owner

Hi Antonio,

I saw that you put a new version, should I try it ? Or no corrections for my issue ?

Many thanks

@Seexelas

Hi again...

given that i'm not 100% sure about what's going on, not sure... OTOH i'm hoping this is just a esbuild side effect and that somehow it will get fixed soon. (and yes esbuild was updated (albeit according to their changelog the changes consumed in last version should - on paper - be immaterial to this particular issue.)

have a great weekend!

@Seexelas
Copy link
Author

Hi Antonio,

I needed to go back to my Docker Image for Homebridge due to some reasons. A did a clean install, and there it is working good on the first setup.

I did a new rasp. setup, and now it is also working...

So case finally closed ^^

Thanks for the time and work.

Nice week end,

@AntonioMeireles
Copy link
Owner

@Seexelas hey again!

can you check by which version that happenned ? (probable culprit was really esbuild but it would be good to know what upstream fix did it for us :-) )

Thanks again!

@Seexelas
Copy link
Author

I will try on the last builds, but not right now, I need to do some tinkering with another problematic issue, I'll come back to you :)

@Nifc4life82
Copy link

I have the same issue could you please upload one of the older updates before the new interface think it’s pre 4.0 as this works with my old Panasonic tv but I updated and now nothing will work to connect it just get spinning cog tryed different browsers but still can’t get it to work

@AntonioMeireles
Copy link
Owner

@Nifc4life82

sorry lag! (work/life not leaving much time left for watching TV or doing OSS development).

can you provide more details about your setup (TV model, logs, etc) ?

@Seexelas things still work for you, right ?

Thanks all for your patience && a great weekend !

@Seexelas
Copy link
Author

Hi,

Yes no issues for me so far :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants