feat: support notebook>=7,<8 (#10)

Co-authored-by: El De-dog-lo <[email protected]>
ApeWorX · Sep 7, 2023 · 2d0c52e · 2d0c52e
1 parent ee72414
commit 2d0c52e
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -29,7 +29,17 @@ python3 setup.py install
 ## Quick Usage
 
 Runs a notebook server:
-`ape notebook`
+
+```bash
+ape notebook
+```
+
+`notebook >=7` has an outstanding issue at launch that can be [resolved](https://github.com/jupyter/notebook/issues/6974#issuecomment-1675394990)
+by running in your environment
+
+```bash
+jupyter lab build
+```
 
 ## Development
 

diff --git a/ape_notebook/_cli.py b/ape_notebook/_cli.py
@@ -1,5 +1,5 @@
 import click
-from notebook.notebookapp import launch_new_instance  # type: ignore
+from notebook.app import launch_new_instance  # type: ignore
 
 
 # %%

diff --git a/setup.py b/setup.py
@@ -57,7 +57,7 @@
     url="https://github.com/ApeWorX/ape-notebook",
     include_package_data=True,
     install_requires=[
-        "notebook>=6.5.4,<7",
+        "notebook>=7.0.0,<8",
         "click>=8.1.3",
         "eth-ape>=0.6.0,<0.7",
     ],