Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update ape core 0.5 #4

Merged
merged 5 commits into from
Sep 23, 2022
Merged

chore: update ape core 0.5 #4

merged 5 commits into from
Sep 23, 2022

Conversation

fmrmf
Copy link
Contributor

@fmrmf fmrmf commented Sep 2, 2022 •
edited
Loading

What I did

  • Updated ape core to >=0.5.0,<0.6.0: fixes issue with cli where ape doesn't recognize ape notebook as a command
  • Updated template dependencies for current state in ApeWorX/project-template
  • Fixed CONTRIBUTING.md for a small typo

How I did it

Changed setup.py file.

How to verify it

  1. Install ape-notebook plugin pointing to this branch with eth-ape>=0.5.0,<0.6.0.
  2. Run ape notebook.
  3. Check notebook server starts in ./notebook/ directory

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@fmrmf fmrmf changed the title chore: update ape core 0.4.0 chore: update ape core 0.5 Sep 23, 2022
fubuloubu
fubuloubu approved these changes Sep 23, 2022
View reviewed changes
.pre-commit-config.yaml
default_language_version:
python: python3.8
python: python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what version is this?

Copy link
Contributor Author

@fmrmf fmrmf Sep 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied over from ape-solidity pre-commit yaml, so this might be wrong. Can add a version or revert the changes if that's better

@fubuloubu
Copy link
Member

fubuloubu commented Sep 23, 2022 •
edited
Loading

alright, I'll merge this one for now. will release as v0.5.0a1 because it still needs a lot of work on the kernel and such

@fubuloubu fubuloubu merged commit 043f2ed into ApeWorX:main Sep 23, 2022
@fubuloubu
Copy link
Member

released! https://pypi.org/project/ape-notebook/0.5.0a1/

@fmrmf
Copy link
Contributor Author

fmrmf commented Sep 23, 2022

woot!

@fmrmf fmrmf deleted the fix-cli branch September 25, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmrmf @fubuloubu