Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setup.py for notebook<7 [APE-1310] #9

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix: setup.py for notebook<7 [APE-1310] #9

merged 1 commit into from
Aug 23, 2023

Conversation

fmrmf
Copy link
Contributor

@fmrmf fmrmf commented Aug 22, 2023

What I did

fixes: #8

How I did it

install_requires=[
   "notebook>=6.5.2,<7",
   ...
]

How to verify it

$ ape notebook

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title fix: setup.py for notebook<7 fix: setup.py for notebook<7 [APE-1310] Aug 22, 2023
@fubuloubu fubuloubu merged commit fccf61a into ApeWorX:main Aug 23, 2023
@fmrmf fmrmf deleted the fix/notebook-version branch August 23, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict to notebook>=6.5.2,<7 [APE-1309]
2 participants
@fmrmf @fubuloubu