Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a productization profile with dep verifier #5299

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

EricWittmann
Copy link
Member

No description provided.

@EricWittmann EricWittmann requested a review from jsenko October 4, 2024 12:30
@jsenko

This comment was marked as outdated.

jsenko

This comment was marked as outdated.

@EricWittmann
Copy link
Member Author

I'm getting spotless violations when I enable the profile. It'll be hard to test the plugin in our upstream workflows, but we can at least check that it fails.

I'm not getting any spotless errors. What command are you running that's giving you the error?

@EricWittmann EricWittmann merged commit d909d35 into main Oct 8, 2024
19 checks passed
@EricWittmann EricWittmann deleted the feat/prod-dep-validator branch October 8, 2024 16:32
EricWittmann added a commit that referenced this pull request Oct 8, 2024
* Added a productization profile with dep verifier

* Update pom.xml

* mark verifier deps as provided
EricWittmann added a commit that referenced this pull request Oct 9, 2024
* Added a productization profile with dep verifier (#5299)

* Added a productization profile with dep verifier

* Update pom.xml

* mark verifier deps as provided

* Change version of parent in verifier pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants