fix: obtain unsearchable views before searching for embeddings #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
khorshuheng
commented
Jan 8, 2025
khorshuheng
commented
- Views which users are not supposed to view will be filtered out at database level, instead of after retrieval.
- Children of trash views should be filtered out as well.
- View that corresponds to space will now be filtered out.
- There is no need to use a transcation, pg pool would do.
- There is no need to join to af_workspace_member.
khorshuheng
force-pushed
the
filter-before-search
branch
from
c7f0554 to
8be255f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.