Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add root view id of the created web template to duplicate published page response #1159

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

khorshuheng
Copy link
Collaborator

Previously, there is no need for returning the newly created page id, because there's no requirement to jump to the duplicated page once the API is called.

However, AppFlowy Web will soon have such requirement, hence the root view id of the duplicate view is required in the response now.

Copy link
Collaborator

@speed2exe speed2exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@appflowy appflowy merged commit 4ddb08e into main Jan 14, 2025
10 of 11 checks passed
@appflowy appflowy deleted the add-duplicate-publish-response branch January 14, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants