Measure sync #772
Merged
Measure sync #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horusiath
force-pushed
the
measure-sync
branch
from
4bb3418 to
cccc880
Compare
lilpoozie2005
approved these changes
Sep 4, 2024
lilpoozie2005
approved these changes
Sep 4, 2024
uxodb
pushed a commit
to uxodb/AppFlowy-Cloud
that referenced
this pull request
Nov 13, 2024
* chore: redesign collab sync protocol to enable injection of metric tracking * chore: track metrics for apply update on the server side * chore: close locks * chore: post rebase fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two metrics:
apply_update_timemeasures time spend on serving the update incoming from client (in milliseconds). This includes total time required to parse update, obtain a collab lock, apply an update and commit transaction.apply_update_sizemeasures size of update (in bytes).We're using histogram here (due to lack of summary support in our prometheus client). We can adjust sizes of buckets over time (I guess).
This required to change the
CollabSyncProtocoldefinitions, so that we have more control over sync step method overrides - otherwise we couldn't include update parsing time into measurements.