Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scoped storage issue on Android 10 #736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ravindu1024
Copy link

Fixed issue where the gallery options were not showing up in the image source picker on Android 10 devices. This is due to the new scoped storage requirements of 10.
Limitations - unable to show gallery types on the picker. I could only manage to show a single file picker.
Test - run "quick start" on an Android 10 device. The gallery intents are not shown without this fix.

@huiseopLee
Copy link

huiseopLee commented Jun 4, 2020

Gallery still doesn't show up in android 10 devices.
library version set 2.8.+
KakaoTalk_Photo_2020-06-04-12-10-08

@ravindu1024
Copy link
Author

@huiseopLee this fix isn't merged to the project yet. You can try my fork which has the Android 10 fix: https://github.com/ravindu1024/Android-Image-Cropper. Just try the latest via jitpack with : implementation 'com.github.ravindu1024:Android-Image-Cropper:2.8.2'

@huiseopLee
Copy link

@huiseopLee this fix isn't merged to the project yet. You can try my fork which has the Android 10 fix: https://github.com/ravindu1024/Android-Image-Cropper. Just try the latest via jitpack with : implementation 'com.github.ravindu1024:Android-Image-Cropper:2.8.2'

sorry but it still doesn't work.
I downloaded and tried your fixed sample app below link, that is also doesn't work.
"https://github.com/ravindu1024/Android-Image-Cropper/tree/android10-gallery-fix"

@ClouddJR
Copy link

I am wondering why adding a file provider to the Manifest file solves the problem. As it is mentioned here, it should be enough to use a regular intent with ACTION_GET_CONTENT. Do you know what exactly causes the gallery to be hidden for some devices on Android 10?

@richiisandii
Copy link

@huiseopLee this fix isn't merged to the project yet. You can try my fork which has the Android 10 fix: https://github.com/ravindu1024/Android-Image-Cropper. Just try the latest via jitpack with : implementation 'com.github.ravindu1024:Android-Image-Cropper:2.8.2'

@ravindu1024 Thank you so much it works!!! Will it also work with older versions?

@behelit
Copy link

behelit commented Sep 8, 2020

On a Pixel 4XL - Android R beta, the 'photos' app is a visible option. I don't believe there are any other 'gallery' apps that come stock with it.

The alternative repo didn't work for me either. It still returns a null uri and crashes.

@Canato
Copy link

Canato commented Nov 27, 2020

Hey!

I start a new project to handover this library
https://github.com/CanHub/Android-Image-Cropper

The ideia is that we keep improving because this project don't have updates since 2018
Hope I can count with your help.

Open to contribute, next pieces of work will be Android 11 permissions, refactor into Kotlin and ActivityContract

@ravindu1024
Copy link
Author

Good idea @Canato. This fix however will become redundant when you implement Android 11 permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants