-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Half-pixel shift in the downscaling step
Should match chroma on most videos now, which makes the shader a little bit better. This obviously breaks it when you have centre chroma, but hopefully this isn't a big issue.
- Loading branch information
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03b7f6a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit made quality of some videos worse, even though all of them have top left chroma loc.
Example from one of them:
Screenshots were taken from this youtube video with
--video-unscaled=yes
. And here is the original YUV 4:4:4 image.Before the commit:
After:
I also should mention that the 37a449a is slightly less saturated than previous 3fc1c1a, which deviates it farther from the original.
Before the 37a449a:
After:
Thank you for taking your time to read this. I hope this was helpful.
03b7f6a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well... Anything other than left chromaloc will look wrong... I knew this would happen, I just don't know how to circumvent the issue...
03b7f6a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add an option to offset for chromaloc, if people see the need for it. Although, no offset 3fc1c1a, in most cases, looks the best out of all chroma upscalers, at least from my testing.
03b7f6a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the change on this repo, cfl does indeed seem to prefer 0 shifts.
03b7f6a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for considering. I'm still kinda curious if the desaturation from 37a449a really needed. Is it to mask the artifacts, or prevent overshooting? Because i don't really see CfL producing values out of the range of the original, unlike KrigBilateral.
03b7f6a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly the 0.8 cap was mostly to prevent the artifacts from looking too ugly.
03b7f6a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I still think the shift was probably correct. Problem on this image is that downsampling with bilinear while also adding a half-pixel shift looks like absolute dogshit.
03b7f6a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand... Are you talking about the GitHub page downsampling? Because example images weren't downsampled at any point on my end, that's why I mentioned the
--video-unscaled=yes
option. There is also a video with the same source image, but at native 720p resolution.I was merely using GitHub page as the fast example for the most obvious differences. Here is the archive
with the uploaded before images. If I'm doing my testing wrong, please let me know.