installer_data: Change default_os_name of all Fedora entries to just 'Fedora Linux'
#350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t 'Fedora Linux' Signed-off-by: badlydrawnface <[email protected]>
badlydrawnface
force-pushed
the
os-name
branch
from
d8f12c3 to
8709cc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't understand a reason why a user would need to have the
default_os_namevariable include the selected desktop as the full name of the stub OS. I think it would be a good idea to changedefault_os_namefrom "Fedora Linux Server / with {desktop environment}" to solely "Fedora Linux", for brevity's sake. I myself tend to rename the default value given in the installer to either "Fedora" or "Fedora Linux". I've also seen a good chunk of YouTubers who've uploaded install videos also change the name of the OS as well.For example, Ubuntu Asahi sets the value to "Ubuntu", for all entries including the server entries, and the previous Arch-based alpha had the name "Asahi Linux".
Now, I know that all these instances have had to deal with only a single supported desktop environment (whereas there are now two) but I think its kind of redundant for a user to be shown this information on the boot menu by default, especially since a user would probably know which desktop they are running by the time they've booted for the first time. I think that such a change would make it less sophisticated for the end user upon entering the boot menu (not like they will have a problem distinguishing it from macOS, most users probably don't triple boot 2 Linuxes and macOS).