Give more data to renderers #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea. Needs tests, doc changes (if any), maybe examples. |
Changaco
force-pushed
the
renderers-more-data
branch
2 times, most recently
from
95a31ce to
81689fd
Compare
Changaco
force-pushed
the
renderers-more-data
branch
from
81689fd to
a92137e
Compare
Changaco
force-pushed
the
renderers-more-data
branch
from
a92137e to
9c9fb67
Compare
|
I've updated the docstrings and added a basic test of a custom renderer. Back to you @pjz. |
|
Am I missing where this tests the added 'renderer-knows-media-type' functionality? |
|
@pjz It's not very straightforward I guess, but it's there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently renderers only get the path of the simplate (
filepath) and the content of the page (raw). It would be useful if they also got the content type (so they can determine the appropriate escaping rules for example, cf AspenWeb/aspen.py-plugins#9) and the position of the page in the simplate (so error messages can use the correct line numbers).This PR makes the
offsetandmedia_typevariables accessible to renderers.