-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to simplify the docs with less abstract wording #12
Conversation
available to downstream functions via :py:mod:`dependency_injection`. Now | ||
Each function returns a :py:class:`dict`, which updates the state of | ||
the current run of the algorithm. Parameters for every function are | ||
automatically fetched from `state` dictionary, using their names as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the
@whit537, okay, take a look. |
@whit537 ping. |
exception handling. | ||
The algorithm in this module is a list of functions that are | ||
executed in defined order, the return values of which update the | ||
algorithm's run state in a `state` dictionary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't you use what I suggested at #12 (comment)?
The model presented in this module is a list of functions that are executed in defined order, the return values of which update the algorithm's run state in a state dictionary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because The model
is too abstract. I tried to make text less academic, because the module provides a fixed algorithm - no need to say model of algorithm
. Perhaps a better wording would be "The module provides a fixed algorithm defined as a list of functions that are executed in sequential order. The return value from each function updates state of algorithm stored in state
dictionary.".
Closing as obsolete. |
No description provided.