Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to simplify the docs with less abstract wording #12

Closed
wants to merge 2 commits into from

Conversation

techtonik
Copy link
Contributor

No description provided.

available to downstream functions via :py:mod:`dependency_injection`. Now
Each function returns a :py:class:`dict`, which updates the state of
the current run of the algorithm. Parameters for every function are
automatically fetched from `state` dictionary, using their names as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the

@techtonik
Copy link
Contributor Author

@whit537, okay, take a look.

@techtonik
Copy link
Contributor Author

@whit537 ping.

exception handling.
The algorithm in this module is a list of functions that are
executed in defined order, the return values of which update the
algorithm's run state in a `state` dictionary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't you use what I suggested at #12 (comment)?

The model presented in this module is a list of functions that are executed in defined order, the return values of which update the algorithm's run state in a state dictionary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because The model is too abstract. I tried to make text less academic, because the module provides a fixed algorithm - no need to say model of algorithm. Perhaps a better wording would be "The module provides a fixed algorithm defined as a list of functions that are executed in sequential order. The return value from each function updates state of algorithm stored in state dictionary.".

@Changaco
Copy link
Member

Closing as obsolete.

@Changaco Changaco closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants