-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[loader] Add fast methods for reading typed arrays #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good.
Can you explain what's so slow about |
Most slow method is |
Just some interop bench results on using
using
using new
|
I see, thanks. However, I'm a bit concerned that this increases the loader's source by about 50%, and I wonder if there's maybe a way to make |
Most of people using babel / webpack / rollup / uglifyjs for browser which could three shaking and remove unused methods during build bundle. For node.js platform size of js is not big deal at all. Also we could build binding tool like |
I agree that we should make this faster, yeah, just hoping that this can be accomplished in less code. |
It will be great do similar stuffs for |
If I might comment on the size problem. Can't we have it the old way?
|
Also, most of us don't mind slightly larger bundle sizes to trade off for speed. Maybe we could make a more performant loader with a larger size and have a smaller one for web bundles? |
Well for instance the loader could be way simplified in node.js environments at least. Could I submit a pull request for a For instance, |
@dcodeIO I leave complete get rid of rest cached |
Ok, I guess it's ready |
bench results