-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Properties To Memory for Each View #815
Conversation
Hmm, interesting. But I worry about performance. Could you please make some perf measurements for |
Is there a benchmark that I could use? Or do you just want a simple one. I mostly changed all the internal views, e.g. I'm also unsure what you mean for minified loader? I didn't know that it was. Non-minified it added 800 bytes. But this functionality was previously available and users will probably be fine with the size. |
I checked size. I used this tool: https://skalman.github.io/UglifyJS-online So this changes add extra 319 bytes and probably could slowdown code (while jit not warmsed up) |
One of the learnings in #810 was that wrapping a buffer in |
Here's an interesting test I made comparing Oops! here: https://jsperf.com/uint8array-new-vs-from |
@willemneal thanks for sharing! Chrome (good)
Firefox (worst)
Which pretty expected that's why we decide remove |
Firefox 68:
So weird! |
Due to some bad results in FF I'm closing this |
Add
U8, I8, ...
properties to memory that wrap the internal buffer with the corresponding view.