fix for isRegistered always true #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 3a4af40): https://astarbase-a4922--pr43-fix-isregistered-alw-pfa0f9mi.web.app (expires Fri, 29 Jul 2022 15:16:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
isRegistered has become a transaction and requiring opening metamask. It should remain a view function and should not change |
niklabh
reviewed
Jul 22, 2022
| else{ | ||
| // if ss58PublicKey32 was 0, it will be encoded as 0x000...000 | ||
| // this will cause chack in isRegister to show len(0)>0 | ||
| delete ss58PublicKey; |
There was a problem hiding this comment.
We cannot modify blockchain state in isRegistered function. It should remain a view function
There was a problem hiding this comment.
you are right. But the reason that this method needs signing is in call to register()
this delete is for the local variable
There was a problem hiding this comment.
Need a view function to show user is registered or not.
niklabh
suggested changes
Jul 22, 2022
|
working fine |
niklabh
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When isRegistered() is called with enabled external database (Shiden only) it will always result with true. The problem is that 0x000...000 will have length>0
Problem fixed with this PR is check for register() when ss58 address is 0.
set isRegistered() to be view function. Remore re-register from the isRegistered() call