feat: add module mint, feeburn #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add mint module's proto * chore: update proto * feat: add mint types * chore: update mint types * chore: update mint params * test: add unittest for mint types * test: update unittest for mint types * feat: add mint keeper * chore: remove inflation module * feat: add API querier * chore: update querier keys * test: add unit tests for mint keeper * test: update unit test for mint keeper * feat: add mint module cli * feat: add rest queries for mint module * chore: update mint module cli * feat: add mint module abci, simulation, genesis * refactor: update mint simulation package * test: add integration test for mint module * docs(mint): add spec for the mint module * chore: add third_party proto's * chore: update main app
# Conflicts: # app/app.go # x/mint/keeper/keeper_test.go # x/mint/keeper/total_minted_provision_test.go # x/mint/types/expected_keepers.go # x/mint/types/query.pb.gw.go
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "context" | ||
| "encoding/json" | ||
| "fmt" | ||
| "math/rand" |
Check failure
Code scanning / gosec
Blocklisted import runtime
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
|
||
| // String implements the Stringer interface. | ||
| func (p Params) String() string { | ||
| out, _ := yaml.Marshal(p) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
* fix: integer overflow * refactor: change parse dec -> int
* add fork code * add fork code * update UpgradeHeight Co-authored-by: hoanguyenkh <[email protected]>
|
look ok |
|
LGTM |
1 similar comment
|
LGTM |
phu-tang
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXX
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...