Redesign DeserializerAdapter trait to support deserializing using DeserializeSeed
#334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovery messages don't implement the serde Deserialize traits because they need an additional encoding value for Deserialization. By using a custom DefaultSeed trait, we can at least work around this issue by providing a dummy implementation.
Enables us to provide a default implementation for `from_bytes_seed`.
Based on cloning the seed.
…zerAdapter. These were not used and no longer useful, because assembly of DATAFRAGs is immplemented without scatter-gather.
|
This branch seems like ready to merge to |
|
Great, thanks a lot for the improvements and the documentation!
Yes, it does. I just updated Atostek/ros2-client#20 based on this PR and tried it with our |
phil-opp
added a commit
to dora-rs/dora
that referenced
this pull request
Apr 15, 2024
Update to use Atostek/RustDDS#334 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of PR #313 . Pull source has been changed to this repository.