Prevent loading of listings when first page of results come preloaded #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jom
force-pushed
the
fix/prevent-jobs-load-headless
branch
from
e9e6588 to
7404d6c
Compare
|
You can see the original functionality here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
ajax-filters.jsdidn't load listings on page load if there were no job filters ([jobs show_filters=false]pre-populates the first page of results. This restores that functionality.Testing instructions:
<div class="job_listings">...</div>and mock the look of[jobs]. This will keepajax-filters.jsfrom loading with an empty query.[jobs show_filters="false"]and verify it loads jobs correctly on multiple pages and maintains state (if you have two pages loaded, click on a listing in result, and click browser's back button, 2 pages should be loaded right away).