Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the CSS rules for quotes #1192

Closed
joyously opened this issue Aug 11, 2017 · 5 comments
Closed

Remove the CSS rules for quotes #1192

joyously opened this issue Aug 11, 2017 · 5 comments

Comments

@joyously
Copy link

joyously commented Aug 11, 2017

These rules remove the default quotes set up by browsers. Most theme authors don't add anything to style the q tag. I think these rules should be removed, so the browser defaults are used. At least the defaults handle nested quotes nicely. With these rules, no quotes at all!

blockquote:before,
blockquote:after,
q:before,
q:after {
	content: "";
}

blockquote,
q {
	quotes: "" "";
}

@grappler
Copy link
Collaborator

@joyously Do you have some screenshots how it looks now and how it would look like when the browser defaults are used?

@joyously
Copy link
Author

These are the browser defaults for q tags. The browser does not have quote defaults for blockquote as far as I can see.

q::before {  content: open-quote; }
q::after  {  content: close-quote; }

Here is the HTML for the example:
<p>My brother told me a joke that ended with, <q>And then she said <q>Put that <em>away</em>!</q> before I could do anything.</q> It was funny, but I don't remember it all.</p>

Here is what it looks like now (no changes):
nested-q-now

Here is what it should look like (browser defaults):
nested-q-rules-removed

@grappler
Copy link
Collaborator

After doing some research I agree. The removing of the quotes style was a remainder from Eric Meyer's reset. 6c47be9

Normalize does not touch the quotes CSS so that the browsers can support the different quotation marks in the different languages.

I made a little test to show how it would look in the different languages without the styling. https://jsfiddle.net/9gtfyak1/1/

Some really interesting information on https://en.wikipedia.org/wiki/Quotation_mark

@davidakennedy
Copy link
Contributor

Thanks for creating this issue @joyously and for the additional information @grappler.

I think this is a good move.

philiparthurmoore added a commit that referenced this issue Sep 15, 2017
Remove CSS rules for quotes - Issue #1192
@grappler
Copy link
Collaborator

grappler commented Sep 17, 2017

Closing as it has been fixed in #1201

youthkee added a commit to littlebirdjp/_s that referenced this issue Oct 31, 2017
…s-diff

* automatic/origin/master: (193 commits)
  Update README.md
  Update template hierarchy link
  Update year to the latest
  Remove extra `!` in `style.scss`
  Remove unnecessary !
  Update screen-reader-text class.
  Fixing "Upload Theme" button text
  Add necessay backticks
  Change links http:// to https://
  Added a note about the need to rename `_s.pot`.
  Travis: build against highest available PHP version
  Remove CSS rules for quotes - Issue Automattic#1192
  Remove unused CSS.
  New lines and spacing.
  File must end with a newline character.
  Load WooCommerce Star fonts via inline styles.
  Adds WooCommerce plugin file paths.
  Fix column-width sass mixin.
  Add commas to each array value.
  Newline character.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants