-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the CSS rules for quotes #1192
Comments
@joyously Do you have some screenshots how it looks now and how it would look like when the browser defaults are used? |
These are the browser defaults for
Here is the HTML for the example: |
After doing some research I agree. The removing of the quotes style was a remainder from Eric Meyer's reset. 6c47be9 Normalize does not touch the quotes CSS so that the browsers can support the different quotation marks in the different languages. I made a little test to show how it would look in the different languages without the styling. https://jsfiddle.net/9gtfyak1/1/ Some really interesting information on https://en.wikipedia.org/wiki/Quotation_mark |
Remove CSS rules for quotes - Issue #1192
Closing as it has been fixed in #1201 |
…s-diff * automatic/origin/master: (193 commits) Update README.md Update template hierarchy link Update year to the latest Remove extra `!` in `style.scss` Remove unnecessary ! Update screen-reader-text class. Fixing "Upload Theme" button text Add necessay backticks Change links http:// to https:// Added a note about the need to rename `_s.pot`. Travis: build against highest available PHP version Remove CSS rules for quotes - Issue Automattic#1192 Remove unused CSS. New lines and spacing. File must end with a newline character. Load WooCommerce Star fonts via inline styles. Adds WooCommerce plugin file paths. Fix column-width sass mixin. Add commas to each array value. Newline character. ...
These rules remove the default quotes set up by browsers. Most theme authors don't add anything to style the
q
tag. I think these rules should be removed, so the browser defaults are used. At least the defaults handle nested quotes nicely. With these rules, no quotes at all!The text was updated successfully, but these errors were encountered: