Prevent broken translations in some locales for the edit post link #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use of screen reader text
grappler
requested changes
Jan 3, 2017
| esc_html__( 'Edit %s', '_s' ), | ||
| the_title( '<span class="screen-reader-text">"', '"</span>', false ) | ||
| /* translators: %s: Name of current post. Only visible to screen readers */ | ||
| __( 'Edit <span class="screen-reader-text">%s</span>', '_s' ), |
There was a problem hiding this comment.
Previously the function was esc_html__(). It is best not to change that.
There was a problem hiding this comment.
That's won't work now that we have the html back in the string.
There was a problem hiding this comment.
Oh, then we will need to use wp_kses() like done here: https://github.com/Automattic/_s/blob/master/inc/template-tags.php#L65
yoavf
changed the title
grappler
approved these changes
Jan 3, 2017
jrfnl
reviewed
Jan 3, 2017
My first instinct was to do just that - but that means (for Hebrew) choosing to omit a word from the screen reader version. It is not a better outcome. |
davidakennedy
added a commit
to davidakennedy/_s
that referenced
this pull request
Jun 9, 2017
davidakennedy
added a commit
to davidakennedy/_s
that referenced
this pull request
Jun 9, 2017
davidakennedy
added a commit
to davidakennedy/_s
that referenced
this pull request
Jun 9, 2017
Tweak Automattic#1066 to fix build errors Adjust location of placeholder text
davidakennedy
added a commit
that referenced
this pull request
Jun 9, 2017
Fix build errors related to #1066
gatespace
added a commit
to gatespace/_s
that referenced
this pull request
Jun 15, 2017
* upstream/master: (31 commits) Improve "Continue reading" word order for i18n Create readme.txt Remove invalid rel="designer" attribute Fix build errors related to Automattic#1066 Adjust location of placeholder text Tweak Automattic#1066 to fix build errors Fix build errors related to Automattic#1066 Remove tags Update README.md to be consistent with new file name Replace extras.php with template-functions.php Update WordPress version and copyright date Switch versions of PHP Code Sniffer for build process Adding ID to comment labels for post CS: Fix code layout of nested function calls with associative arrays. I18n: ensure all text strings with placeholders have translators comments. Code obfuscation: Fix assignment within a condition I18n: Fix a translation call for a text string which needs context Update readme.txt doctype uppercase to lowercase clarify who maintains _s and standardize returns in CONTRIBUTING.md ... # Conflicts: # languages/_s.pot
gatespace
added a commit
to gatespace/_s
that referenced
this pull request
Jun 15, 2017
* Update copyright year. * Add comments for translators. * Translation fix for a comment strings * Added translation word by code change. see Automattic#1100, Automattic#1066 Automattic#1117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #775, the translation of the edit post link in some languages can end up forming a partial sentence.
By default, in English, the visual output is the word "Edit".
In Hebrew for example, the translation would be a single word:
With the addition of the post title, the translator is instructed to translate
Edit %swith%sbeing the post name. In Hebrew, the translation will beNote the added word
אתTo quote from this post:
The end visual result in Hebrew would be:
Which is weird. Think of it as "Edit The" (without the actual object).
This PR fixes that by expanding the comment to note that the post name only visible to screen readers, and puts the screen reader span html inside the translated string.
The translator for Hebrew can now do something like
לערוך <span class="screen-reader-text">את %s</span>, putting the את word inside the invisible span.