Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RTL the right way #1154

Closed
wants to merge 2 commits into from
Closed

Conversation

grappler
Copy link
Collaborator

@grappler grappler commented Jul 1, 2017

@yoavf gave a talk on "Right To Left Languages Support – The Right Way"

In his talk he discourages the use of rtl.css but instead use style-rtl.css which would be a replacement for style.css instead of rtl.css which override the ltr styles with rtl styles.

There are a couple of reasons why this is better.

  • RTL users do not have worse performance by having to load an extra file for their styles.
  • The RTL file can be generated automatically without having manually to change the design.

The style-rtl.css can be generated using a node task. After installing it npm install -g rtlcss, the generation happens with rtlcss style.css style-rtl.css. This is similar to the tool used to generate the CSS from Sass in #1149.

https://yoav.blog/2017/06/22/right-to-left-in-wordpress-the-right-way/

@davidakennedy
Copy link
Contributor

I'm going to leave this for now. We need to work through the automation/build process items before moving on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants