Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yoavf gave a talk on "Right To Left Languages Support – The Right Way"
In his talk he discourages the use of
rtl.css
but instead usestyle-rtl.css
which would be a replacement forstyle.css
instead ofrtl.css
which override the ltr styles with rtl styles.There are a couple of reasons why this is better.
The
style-rtl.css
can be generated using a node task. After installing itnpm install -g rtlcss
, the generation happens withrtlcss style.css style-rtl.css
. This is similar to the tool used to generate the CSS from Sass in #1149.https://yoav.blog/2017/06/22/right-to-left-in-wordpress-the-right-way/