Remove unnecessary ! #1220
Merged
Remove unnecessary ! #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@B-07 Thanks for the PR. Great catch! One thing I'll mention: please put an explanation of your changes in the PR. No matter how simple. It's tedious sometimes, yes. However, this is a good habit to learn as a developer because:
Thanks again for your contributions! |
|
@davidakennedy Thank for the suggestions, I'll follow those from now on for sure. |
|
@davidakennedy I don't think this was supposed to be removed. We added it deliberately in e9c7d73 in #770 |
|
Ah, I looked and missed that @grappler! Thanks for catching it. Will revert. |
davidakennedy
added a commit
that referenced
this pull request
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Related issue(s):