Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url to the list of input selectors #280

Merged
merged 1 commit into from
Aug 11, 2013
Merged

Add url to the list of input selectors #280

merged 1 commit into from
Aug 11, 2013

Conversation

jayj
Copy link
Contributor

@jayj jayj commented Aug 6, 2013

The new core markup for the comment form uses the url input type but there's no styling for it in _s yet.

@gatespace
Copy link
Contributor

+1.

I want to also add input[type="tel"].
This is used in the Contact form 7.

@jayj
Copy link
Contributor Author

jayj commented Aug 8, 2013

The whole list:

input[type="text"],
input[type="color"],
input[type="email"],
input[type="number"],
input[type="password"],
input[type="search"],
input[type="tel"],
input[type="url"],
input[type="datetime"],
input[type="datetime-local"],
input[type="date"],
input[type="month"],
input[type="time"],
input[type="week"] {

}

@gatespace
Copy link
Contributor

thx, @jayj
good.

@obenland
Copy link
Member

Let's stick with what comes with core for now.

obenland added a commit that referenced this pull request Aug 11, 2013
Add `url` to the list of input selectors.
@obenland obenland merged commit a462ad5 into Automattic:master Aug 11, 2013
@jayj jayj deleted the jayj-underscores-url-selector branch August 11, 2013 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants