Inherit box-sizing for best practice #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using inheritance allows easy override on other elements, and also it’s the best practice.
|
I think this is a good improvement, but as it changes a foundation style it would be great to get other opinions. |
|
I've been doing this for a while now in my Underscores usage and it's worked fine. |
|
Big fan of this. Let's get it in. |
|
Absolutely +1! |
|
Go for it @philiparthurmoore! ;) |
|
@obenland Sure! Just waiting on the Sass/style.css stuff to get sorted out. :) |
|
Ah, good to know, let me comment on that then :) |
|
Ah! I totally missed that @philiparthurmoore, should I compile it in a commit? |
|
I didn't spot this so I submitted a separate patch that does the same thing. My patch has SASS as well. #630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using inheritance allows easy override on other elements, and also it’s the best practice. Paul Irish and CSSTricks have also switched and recommend this method.