Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New heading structure #651

Closed
wants to merge 14 commits into from
Closed

New heading structure #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1e8d4a9
Aims to create a more hierarchical heading structure. Somewhat based …
mor10 Nov 25, 2014
3b68b50
Revert "Aims to create a more hierarchical heading structure. Somewha…
mor10 Nov 25, 2014
4e06d24
Aims to create a more hierarchical heading structure. Somewhat based …
mor10 Nov 25, 2014
a6c9caf
semantic cleanup of tabs.
mor10 Nov 25, 2014
1e8a2d3
Tab and whitespace cleanup to comply with Travis CI
mor10 Nov 28, 2014
a8fa060
Based on recommendation by @davidakennedy adding contingency in index…
mor10 Jan 24, 2015
5bb0534
Merge pull request #770 from circlecube/patch-1
obenland Jun 19, 2015
64d2e76
Aims to create a more hierarchical heading structure. Somewhat based …
mor10 Nov 25, 2014
4293c67
Based on recommendation by @davidakennedy adding contingency in index…
mor10 Jan 24, 2015
9d7fc71
Merge branch 'new_heading_structure' of https://github.com/mor10/_s i…
mor10 Jun 27, 2015
b3110fe
Change markup for widget titles to H2 to preserve semantic hierarchy.
mor10 Jun 27, 2015
fd76b25
Updated Tagline markup as per WC3 guidelines.
sagarjadhav May 29, 2015
afdcb3e
update theme comment section so it will remain when compiled & compre…
circlecube Jun 18, 2015
dc0213f
Merge branch 'new_heading_structure' of https://github.com/mor10/_s i…
mor10 Jun 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ function _s_widgets_init() {
'description' => '',
'before_widget' => '<aside id="%1$s" class="widget %2$s">',
'after_widget' => '</aside>',
'before_title' => '<h1 class="widget-title">',
'after_title' => '</h1>',
'before_title' => '<h2 class="widget-title">',
'after_title' => '</h2>',
) );
}
add_action( 'widgets_init', '_s_widgets_init' );
Expand Down
6 changes: 5 additions & 1 deletion header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@

<header id="masthead" class="site-header" role="banner">
<div class="site-branding">
<h1 class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></h1>
<?php if ( is_front_page() && is_home() ) : ?>
<h1 class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></h1>
<?php else : ?>
<div class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></div>
<?php endif; ?>
<p class="site-description"><?php bloginfo( 'description' ); ?></p>
</div><!-- .site-branding -->

Expand Down
6 changes: 6 additions & 0 deletions index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@

<?php if ( have_posts() ) : ?>

<?php if ( is_home() && ! is_front_page() ) : ?>
<header>
<h1 class="page-title screen-reader-text"><?php single_post_title(); ?></h1>
</header>
<?php endif; ?>

<?php /* Start the Loop */ ?>
<?php while ( have_posts() ) : the_post(); ?>

Expand Down
2 changes: 1 addition & 1 deletion template-parts/content-search.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
<header class="entry-header">
<?php the_title( sprintf( '<h1 class="entry-title"><a href="%s" rel="bookmark">', esc_url( get_permalink() ) ), '</a></h1>' ); ?>
<?php the_title( sprintf( '<h2 class="entry-title"><a href="%s" rel="bookmark">', esc_url( get_permalink() ) ), '</a></h2>' ); ?>

<?php if ( 'post' == get_post_type() ) : ?>
<div class="entry-meta">
Expand Down
2 changes: 1 addition & 1 deletion template-parts/content.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
<header class="entry-header">
<?php the_title( sprintf( '<h1 class="entry-title"><a href="%s" rel="bookmark">', esc_url( get_permalink() ) ), '</a></h1>' ); ?>
<?php the_title( sprintf( '<h2 class="entry-title"><a href="%s" rel="bookmark">', esc_url( get_permalink() ) ), '</a></h2>' ); ?>

<?php if ( 'post' == get_post_type() ) : ?>
<div class="entry-meta">
Expand Down