Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing wp_title in extras #793

Closed
wants to merge 1 commit into from
Closed

Conversation

shelbyKiraM
Copy link

It was checking if we’re on an older version than 4.1, and gets the
full title passed to the function, and appends.

It was checking if we’re on an older version than 4.1, and gets the
full title passed to the function, and appends.
@obenland
Copy link
Member

obenland commented Aug 8, 2015

It was checking if we’re on an older version than 4.1, and gets the full title passed to the function, and appends.

Correct, that is what the code is supposed to do. If we're on 4.1 or later we'll use add_theme_support( 'title-tag' ); and don't care about the wp_title callback, because the built-in feature does that for us.

We also want to only append the blog name as to not overwrite the true title. We want to enhance it, not replace it.

@philiparthurmoore
Copy link
Collaborator

Not a relevant PR anymore. See #798 and 8e9678b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants