Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SASS spacing for consistency. #893

Closed
wants to merge 3 commits into from
Closed

Fixed SASS spacing for consistency. #893

wants to merge 3 commits into from

Conversation

MarkBatchelder
Copy link
Contributor

Just added lines where there should have been one and broke some lines into multiple lines where they included more than one element. Really just added lines to SASS files to keep things consistent with the rest of the SASS and CSS.

@obenland
Copy link
Member

Removing new lines from the end of those files would introduce an inconsistency with the rest of _s files.

@MarkBatchelder
Copy link
Contributor Author

I put all of the blank lines at the end of files back. Obviously I didn't think they were necessary, :P but I can see what you're talking about.

@karmatosed
Copy link
Contributor

Can you look at the CSS output too?

@MarkBatchelder
Copy link
Contributor Author

Slowly reviewing things; actually finding a couple more things I could change for consistency and now matching it up with style.css.

@MarkBatchelder
Copy link
Contributor Author

There are two files that still don't match up, but they have nothing to do with the changes I've made. We could also change the order of a few elements in style.css to match the way the SASS is compiled because of nesting. But the only other differences are the fault of the SASS compiler.

@MarkBatchelder
Copy link
Contributor Author

To clarify, I just added spaces between selectors that needed them and listed selectors on separate lines instead of a single line.

Before:
blockquote, q {

After:
blockquote,
q {

Also: 9a08ca0

@karmatosed
Copy link
Contributor

There are conflicts that need resolving before we can work on this, can you take a look please @WPAddiction ?

@m-e-h m-e-h mentioned this pull request Jul 23, 2017
@grappler
Copy link
Collaborator

As there are a number of conflicts in this PR it would be best to create a new PR if need be. Please see the discussion in #1149 as to the future workings of CSS and Sass.

@grappler grappler closed this Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants