-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add starscape block #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💖 Tested it out and looks great, no problems
icon, attributes, editorScript, script, editorStyle, and style could not be added at this time because they all depend on imported files that are all webpacked together in the current build process
Really good stuff! Here something that can help 1. Functionally 2. Verbally Editor To reduce copy in the sidebar to the basic: Current: The maximum dimensions control how far out to render stars. It does not change the size of the container. Keep these values as small as possible, especially with higher density stars, for better performance on low-powered devices. New: Control the area of stars you want. The smaller the values, the better the performance. Plugin 3. Visually |
@pablohoneyhoney I love the icon and graphics you added! Just a couple questions/comments: 1. Functionality a. I currently have the theme colors, plus black and white as available text colors. Should I make that palette a fixed set of colors to match the colors in the mockups instead? b. Custom gradients aren't supported yet, unfortunately, so I want to still give enough flexibility. If I cut the number of choices in half—to just 12—would you say that's still too many? 2. Verbally I think I need to clarify the purpose of the dimensions option better. Simply saying a smaller number is better seems to imply that the obvious thing to do is to just make them zero for best performance. While that would perform the best, you also wouldn't see any stars. More realistically, let's say you're editing on mobile or on some other smaller-than-average screen. You lower the numbers because you want better performance. It looks good on your screen, but upon opening it up on desktop, you see that there aren't any stars at the top, and there is an obvious arc where they stop which doesn't look good. On the flip-side if you optimize for an 8k screen to future-proof the whole thing, when loading the page on mobile, most of those stars won't ever appear on screen, but the phone would still have to download and parse an extra few kB of CSS, and the animation may be jittery. The default values I have set work fine up to a full-height starscape on a 1080p Full-HD screen. In my testing, bumping it up to 4k caused jank on mobile. If people really care about 4k and don't care at all about mobile, they can increase the values. If the site is running almost exclusively on mobile those number can be lowered so their mobile users use less data. |
I think 12 feels a more palatable range. We can always optimize from there. RE: dimensions, I understand, but as a good practice, we shouldn't rely on heavy copy to explain something like this in the sidebar. Can we limit the dimensions to optimized multi-screen ranges? Or can we edit the dimensions by device (desktop-mobile)? |
Released on the WordPress.org plugin directory: https://wordpress.org/plugins/starscape/ |
Description
Adds a starscape motion background block with a simple text entry.
Available options:
Screenshots