Skip to content

Commit

Permalink
[not verified] Update site type answer text (#26536)
Browse files Browse the repository at this point in the history
* Update text to conflict less with the agency answer

* changelog

* Update tests to include new text

* Fix typo in test
  • Loading branch information
CodeyGuyDylan authored and dkmyta committed Oct 1, 2022
1 parent a0702c7 commit 1d71f37
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const SiteTypeQuestionComponent = props => {
/>
<CheckboxAnswer
answerKey={ 'site-type-personal' }
title={ __( 'This is my personal site', 'jetpack' ) }
title={ __( 'This is a personal site', 'jetpack' ) }
info={ __(
'You built this site yourself, nice work! Personal sites include things like blogs, resume sites, wedding sites, and hobby sites.',
'jetpack'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ describe( 'Recommendations – Site Type', () => {
expect( screen.getByText( 'Tell us more about Test Site?' ) ).toBeInTheDocument();
expect( screen.getByText( 'I build or manage this site for a client' ) ).toBeInTheDocument();
expect( screen.getByText( 'This is an e-commerce site' ) ).toBeInTheDocument();
expect( screen.getByText( 'This is my personal site' ) ).toBeInTheDocument();
expect( screen.getByText( 'This is a personal site' ) ).toBeInTheDocument();
} );

it( 'shows questions with the right default initial state', () => {
Expand All @@ -81,7 +81,7 @@ describe( 'Recommendations – Site Type', () => {
} );
expect( screen.getByLabelText( 'I build or manage this site for a client' ) ).toBeChecked();
expect( screen.getByLabelText( 'This is an e-commerce site' ) ).toBeChecked();
expect( screen.getByLabelText( 'This is my personal site' ) ).not.toBeChecked();
expect( screen.getByLabelText( 'This is a personal site' ) ).not.toBeChecked();
} );

it( 'updates the state of a question when an answer is clicked', async () => {
Expand All @@ -95,7 +95,7 @@ describe( 'Recommendations – Site Type', () => {
initialState: buildInitialState(),
} );

const personalCheckbox = screen.getByLabelText( 'This is my personal site' );
const personalCheckbox = screen.getByLabelText( 'This is a personal site' );
expect( personalCheckbox.checked ).toBe( false );

await user.click( personalCheckbox );
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: enhancement

Update text on site type question to conflict less with the agency/developer answer
2 changes: 1 addition & 1 deletion projects/plugins/jetpack/to-test.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ There have been updates for the Jetpack Recommendations Assistant. In particular

- With the Jetpack Beta Tester [plugin](https://jetpack.com/download-jetpack-beta/) activated, and the 11.4-beta branch active, on the main dashboard page `/wp-admin/admin.php?page=jetpack#/dashboard` there is an option in the footer to "Reset Options (dev only)" which can be used to reset the recommendation steps if they have already been completed.
- Navigate to `/wp-admin/admin.php?page=jetpack#/recommendations/site-type`
- Select "This is my personal site".
- Select "This is a personal site".
- Then select "Continue", it should skip straight to the Downtime Monitoring recommendation.
- Navigate back to `/wp-admin/admin.php?page=jetpack#/recommendations/site-type`
- This time, select the "I build or manage this site for a client" option.
Expand Down

0 comments on commit 1d71f37

Please sign in to comment.