PHP Deprecated: strpos(): Passing null to parameter #1 () of type str…

…ing is deprecated in /wordpress/plugins/jetpack/11.3-a.7/functions.compat.php on line 94
Automattic · Aug 23, 2022 · 1f4ad20 · 1f4ad20
1 parent d5e90d4
commit 1f4ad20
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/projects/plugins/jetpack/changelog/fix-atomic-php-warnings b/projects/plugins/jetpack/changelog/fix-atomic-php-warnings
@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+Compat: wp_startswith should only pass to strpos if string is passed.
diff --git a/projects/plugins/jetpack/functions.compat.php b/projects/plugins/jetpack/functions.compat.php
@@ -86,11 +86,14 @@ function youtube_sanitize_url( $url ) {
 	/**
 	 * Check whether a string starts with a specific substring.
 	 *
-	 * @param var    $haystack String we are filtering.
+	 * @param string $haystack String we are filtering.
 	 * @param string $needle The substring we are looking for.
 	 * @return bool
 	 */
 	function wp_startswith( $haystack, $needle ) {
+		if ( ! $haystack || ! is_string( $haystack ) ) {
+			return false;
+		}
 		return 0 === strpos( $haystack, $needle );
 	}
 endif;