Slideshow one image #1046
Merged
Slideshow one image #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rase- can you take a look at what is needed to make this work, or if it is even needed at all anymore? |
|
Still happens in master. |
rase-
force-pushed
the
slideshow-one-image
branch
from
3eeb80c to
469f10b
Compare
|
Looks much better, but doesn't show caption on the slideshow when there's only one image. Looking into it. |
The jQuery cycle plugin adds `position: relative` when cycling is started. When a single image slideshow is initialized, the cycle isn't started, since there is no need to cycle. Without `position: relative` the caption isn't shown, however. The style is now specified manually.
|
Fixed the issue with caption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20