Gardening action: add new Flag OSS feature #19382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I chose to only add a label for now. In the future we could opt to do more (add a welcome comment, ...) - I chose to look at how they worked on their PR (from a fork) instead of looking at the organization listed in their profile to decide whether they would be considered as outside contributors.
This brings the feature in line with the existing tool we use today in the Calypso repo.
jeherve
added
Actions
github-actions
bot
added
the
[Action] Repo Gardening
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
We have fork checks inside the action anyway.
That's not an option from forks. We could aim to open things up via pull_request_target. Not doing that just yet though. See https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
|
I'll close this for now. The limitations of |
github-actions
bot
added
the
[Status] Needs Author Reply
Since those events will need to be triggered for folks using forks, we cannot rely on just pull_request.
jeherve
added
[Status] Needs Review
kraftbj
added
[Status] Ready to Merge
github-actions
bot
removed
the
[Status] Ready to Merge
jeherve
added a commit
that referenced
this pull request
Apr 16, 2021
Follow-up from #19382. We need to allow the action to run from forks for pull_request_target events, so we can add labels to PRs created by external contributors.
|
Tested this, and it turns out it will need a follow-up: #19554 |
jeherve
added a commit
that referenced
this pull request
Apr 16, 2021
Follow-up from #19382. We need to allow the action to run from forks for pull_request_target events, so we can add labels to PRs created by external contributors.
jeherve
added a commit
to Automattic/vaultpress
that referenced
this pull request
Apr 19, 2021
This allows adding a label and posting a Slack message every time someone opens a PR from a fork. See Automattic/jetpack#19382 Internal reference: p3btAN-1nR-p2#comment-13830
jeherve
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Apr 19, 2021
This allows adding a label and posting a Slack message every time someone opens a PR from a fork. See Automattic/jetpack#19382 Internal reference: p3btAN-1nR-p2#comment-13830
This was referenced Apr 19, 2021
jeherve
added a commit
to Automattic/wp-desktop
that referenced
this pull request
Apr 19, 2021
This allows adding a label and posting a Slack message every time someone opens a PR from a fork. See Automattic/jetpack#19382 Internal reference: p3btAN-1nR-p2#comment-13830
jeherve
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Apr 20, 2021
This allows adding a label and posting a Slack message every time someone opens a PR from a fork. See Automattic/jetpack#19382 Internal reference: p3btAN-1nR-p2#comment-13830
jeherve
added a commit
to Automattic/vaultpress
that referenced
this pull request
Apr 20, 2021
This allows adding a label and posting a Slack message every time someone opens a PR from a fork. See Automattic/jetpack#19382 Internal reference: p3btAN-1nR-p2#comment-13830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR brings an additional task to the Gardening action, based on an existing feature currently enabled for the Calypso repo:
This new action flags PRs opened by external contributors (not from a branch on the main repo), adds the "OSS Citizen" label, and posts a Slack message to your team channel to let everyone know you've got a contribution from an external contributor.
Note: I chose to look at how they worked on their PR (from a fork) instead o
f looking at the organization listed in their profile to decide whether they
would be considered as outside contributors.
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
pull_request_target, we will not be able to test much before this gets merged. Then once this is merged, I'll open a test PR from a fork to test things in the #jeherve-debug channel.