Widget visibility: Add support for old-style single widgets

[jeherve]

Props @westonruter

Fixes the following notice:
Undefined offset: 1 at /jetpack/modules/widget-visibility/widget-conditions.php line 251

This is the line that is erroring
list( $basename, $suffix ) = explode( "-", $widget_id, 2 );
The problem is that it assumes the a -number on the end of the widget name

This is not safe as you can widget names like:
icl_lang_sel_widget
recent-comments-2

For more details, view the original ticket:
http://plugins.trac.wordpress.org/ticket/1979

[georgestephanis]

@cfinke -- thoughts?

[blobaugh]

@jeherve do you have access to WPML or know of another plugin/widget that caused that notice to test against?

[jeherve]

I reproduced the issue by creating an old single widget, like so:

add_action("widgets_init", array('Widget_name', 'register'));
register_activation_hook( __FILE__, array('Widget_name', 'activate'));
register_deactivation_hook( __FILE__, array('Widget_name', 'deactivate'));
class Widget_name {
  function activate(){
    $data = array( 'option1' => 'Default value' ,'option2' => 55);
    if ( ! get_option('widget_name')){
      add_option('widget_name' , $data);
    } else {
      update_option('widget_name' , $data);
    }
  }
  function deactivate(){
    delete_option('widget_name');
  }
    function control(){
        $data = get_option('widget_name');
        ?>
        <p><label>Option 1<input name="widget_name_option1"
    type="text" value="<?php echo $data['option1']; ?>" /></label></p>
        <p><label>Option 2<input name="widget_name_option2"
    type="text" value="<?php echo $data['option2']; ?>" /></label></p>
        <?php
         if (isset($_POST['widget_name_option1'])){
            $data['option1'] = attribute_escape($_POST['widget_name_option1']);
            $data['option2'] = attribute_escape($_POST['widget_name_option2']);
            update_option('widget_name', $data);
        }
    }
  function widget($args){
    echo $args['before_widget'];
    echo $args['before_title'] . 'Your widget title' . $args['after_title'];
    echo 'I am your widget';
    echo $args['after_widget'];
  }
  function register(){
        wp_register_sidebar_widget( 'my_widget_id', 'Widget name', array('Widget_name', 'widget'));
    wp_register_widget_control( 'my_widget_id', 'Widget name', array('Widget_name', 'control'));
  }
}

[mjangda]

FYI, This breaks widgets that have no settings. Working off the example widget above:

add_action("widgets_init", array('Widget_name', 'register'));

class Widget_name {
 function widget($args){
    echo $args['before_widget'];
    echo $args['before_title'] . 'Your widget title' . $args['after_title'];
    echo 'I am your widget';
    echo $args['after_widget'];
  }
  function register(){
       wp_register_sidebar_widget( 'my_widget_id', 'Widget name', array('Widget_name', 'widget'));
  }
}

The widget doesn't render when added to a sidebar.

[georgestephanis]

I'll revert.

[mjangda]

Simple fix:

Index: widget-conditions.php
===================================================================
--- widget-conditions.php       (revision 89338)
+++ widget-conditions.php       (working copy)
@@ -275,7 +275,7 @@
                                }

                                // Old single widget
-                               else if ( false === self::filter_widget( $settings[$id_base] ) ) {
+                               else if ( ! empty( $settings[ $id_base ] ) && false === self::filter_widget( $settings[$id_base] ) ) {
                                        unset( $widget_areas[$widget_area][$position] );