-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection: send package versions on init hook #21173
Conversation
Fixes #21165 Send the package versions to wpcom on the init hook instead of plugins loaded to prevent a conflict with a third party plugin. The plugin isn't ready until the 'after_setup_theme' action has fired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some suggested test cases for this PR.
Connection
- In-place connection with free plan
- In-place connection with paid plan
- In-place connection with product purchase
- Classic connection. Use Safari, or set a constant
JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME
to true - Disconnect/reconnect connection
- Secondary user connection
- Connection on multisite
Verify that the changes are compatible with the plugins that use the connection package.
- WooCommerce Payments
- Jetpack Boost
- Previous versions of Jetpack
If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
@kbrown9 Following up -- could we set this even later? I noticed while testing Jetpack on a site that this API call added about a half-second to the execution time and, as far as I can tell, it isn't providing benefit to the visitor. Could we add this to just |
Fixes #21165 Send the package versions to wpcom on the init hook instead of plugins loaded to prevent a conflict with a third party plugin. The plugin isn't ready until the 'after_setup_theme' action has fired. Co-authored-by: Jeremy Herve <[email protected]> Co-authored-by: Samiff <[email protected]>
Fixes #21165
Changes proposed in this Pull Request:
Send the package versions to wpcom on the
init
hook instead ofplugins_loaded
to prevent a conflict with a third party plugin. The plugin isn't ready until theafter_setup_theme
action has fired.Is there any reason that we shouldn't move the package version check and wpcom request to the init hook? This seems like a safe change to me.
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
jetpack_package_versions
option has been set:wp option get jetpack_package_versions