Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules Admin: Allow VideoPress module to be managed for any plan #21200

Merged
merged 3 commits into from
Sep 27, 2021

Conversation

roundhill
Copy link
Contributor

@roundhill roundhill commented Sep 27, 2021

This is a follow-up to #21006 where we add support for the Jetpack VideoPress product and enable it for free sites. We missed that there was a separate module management page in Jetpack that needed changes to support this same functionality.

The VideoPress module will now be able to be activated by any plan, including free:

Screen Shot 2021-09-27 at 11 28 05 AM

Changes proposed in this Pull Request:

  • Enables the VideoPress module on the modules management view for any plan.

Jetpack product discussion

pxWta-Zz-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Apply D66710-code to your wp.com sandbox if it hasn't been merged yet, sandbox public-api.wordpress.com, and enable JETPACK__SANDBOX_DOMAIN on your Jetpack dev site so that it points to your wp.com sandbox. You also may need to enable HTTP access on your WP.com sandbox.
  • On your WordPress.com sandbox, enable the feature flag for Jetpack VideoPress in mu-plugins/videopress/constants.php: define( 'VIDEOPRESS_JETPACK_VIDEO_ENABLED', true );
  • Remove all plan/upgrades so you are on the free Jetpack plan.
  • Visit the dashboard, then click on Modules at the bottom of the screen.
  • You should be able to activate the VideoPress module.
  • Also try activating the module with the bulk-select tool, it should work.
  • Head over to the media library and upload a video. If no videos were uploaded to the site previously, it should be uploaded successfully.
  • Any video uploaded after the first upload should error out.

@roundhill roundhill requested a review from jgcaruso September 27, 2021 17:32
@roundhill roundhill added [Feature] VideoPress A feature to help you upload and insert videos on your site. [Status] Needs Team Review labels Sep 27, 2021
@roundhill roundhill added this to the jetpack/10.2 milestone Sep 27, 2021
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Sep 27, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: October 5, 2021.
  • Scheduled code freeze: September 28, 2021.

Copy link
Contributor

@jgcaruso jgcaruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR works as described!

@roundhill roundhill added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Team Review labels Sep 27, 2021
@samiff samiff self-requested a review September 27, 2021 18:31
@samiff samiff enabled auto-merge (squash) September 27, 2021 18:40
@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 27, 2021
@samiff samiff merged commit c80709b into master Sep 27, 2021
@samiff samiff deleted the update/videopress-enable-in-modules branch September 27, 2021 18:53
@samiff samiff added [Status] Needs Testing We need to add this change to the testing call for this month's release and removed [Status] Needs Testing We need to add this change to the testing call for this month's release labels Sep 27, 2021
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 29, 2021
retrofox pushed a commit that referenced this pull request Oct 1, 2021
…or any plan (#21200)

* Allow VideoPress module to be activated for any plan including free.

* Adding changelog entry.

Co-authored-by: Samiff <[email protected]>
@jeherve jeherve removed the [Status] Needs Testing We need to add this change to the testing call for this month's release label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] VideoPress A feature to help you upload and insert videos on your site. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants