Connection: include to define wp_generate_password if necessary

[jeherve]

Fixes #23835

Changes proposed in this Pull Request:

This may not be the right approach, but may be a workaround for the problem described in #23835.

I worry a bit about trying to include a core file from the package directly, ideally we wouldn't have to do that. I don't know if that could ever be an issue.

Jetpack product discussion

• N/A

Does this pull request change what data or activity we track or use?

• No

Testing instructions:

I wasn't able to reproduce the original issue, but this may be worth trying:

1. Install and connect Jetpack.
2. Go to Plugins > Add New
3. Install the Passwords Evolved plugin.
4. Click to activate it.
5. Check your logs to ensure no Fatal happened.

[test-case-reminder]

Here are some suggested test cases for this PR.

Connection

• In-place connection with free plan
• In-place connection with paid plan
• In-place connection with product purchase
• Classic connection. Use Safari, or set a constant JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME to true
• Disconnect/reconnect connection
• Secondary user connection
• Connection on multisite

Verify that the changes are compatible with the plugins that use the connection package.

• WooCommerce Payments
• Jetpack Boost
• Previous versions of Jetpack

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

[fgiannar]

Many thanks for trying to fix this, Jeremy and apologies for the delayed reply.

Looking at the corresponding bug I noticed that Kraft managed to resolve this the first time by moving the external package tracker request to shutdown.

The issue was indeed resolved but then came back because of another external request, introduced by the search package this time, aimed to fetch the search plan info from WPCOM and triggered here.

Therefore I wonder if it would make sense to reach out to @Automattic/jetpack-search and discuss a similar approach.

[jeherve]

introduced by the search package this time, aimed to fetch the search plan info from WPCOM and triggered here.

Nice!

I have to ask, how did you trace the problem back to this new call?

I wonder if it would make sense to reach out to https://github.com/orgs/Automattic/teams/jetpack-search and discuss a similar approach.

Yeah, that seems like the best course of action here!

Maybe we should also add a test to ensure that this doesn't happen again in the future.

[fgiannar]

have to ask, how did you trace the problem back to this new call?

Based on the corresponding fatal logs provided in #23835 (under Other Information).

Maybe we should also add a test to ensure that this doesn't happen again in the future.

That would be great, however given this is so hard to reproduce I'm not sure how we could structure it. Even an e2e test with the Passwords Evolved plugin activated could prove flaky given we never managed to find a scenario where this is always reproducible. If any better ideas come to mind pls let me know and I'll be happy to work on this.

[jeherve]

Closing this for now because of the lack of activity on this. We can always reopen in the future if needed.