Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Activate plugins in normal mode #25727

Merged
merged 6 commits into from
Aug 23, 2022

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Aug 19, 2022

Changes proposed in this Pull Request:

  • Do not use Silent mode when activating plugins from My Jetpack.

This was done to avoid errors caused by the redirects, but now plugins won't redirect by default and it's safe to activate in normal mode.

This way we trigger the activated_plugin hook and make sure plugins are properly activated

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

p9dueE-5CL-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Remove Jetpack plugin (only deactivating won't do it). On the monorepo you can do jetpack docker unlink-plugin jetpack
  • Activate and connect only Protect
  • Go to My Jetpack
  • Activate Backup and confirm the Backup plugin gets activated without errors
  • Do the same for Search and Social
  • Install Jetpack jetpack docker link-plugin jetpack
  • Go to My Jetpack and activate "Extras"
  • Confirm Jetpack plugin gets activated without errors

@leogermani leogermani added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Aug 19, 2022
@leogermani leogermani self-assigned this Aug 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on jurassic ninja 👍

@leogermani leogermani merged commit b8d569d into trunk Aug 23, 2022
@leogermani leogermani deleted the update/my-jetpack-activate-plugins branch August 23, 2022 18:18
@leogermani leogermani removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants