-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update site type question on wp admin home #26540
Conversation
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, and test well in all mentioned scenarios!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well for me and I was able to see the correct offerings.
* Update site type question on banner * Update site-type banner question * changelog
cherry-picked to |
* Update site type question on banner * Update site-type banner question * changelog
* Update site type question on banner * Update site-type banner question * changelog
A previous PR was created to update the
site-type
recommendation question, but the banner version of this question was overlooked. This PR edits the banner version to be the same as the one in the assistantChanges proposed in this Pull Request:
Replace the answers in the
site-type
question on the banner of wp-admin/index.php. It also updates the slugs behind it so that it can correctly direct users to the right recommendations when redirected to the assistant after answering the question.Other information:
Jetpack product discussion
P2: p8oabR-Wd-p2#comment-6607 and pbNhbs-3pg-p2
Does this pull request change what data or activity we track or use?
No it does not
Testing instructions:
/wp-admin/admin.php?page=jetpack#/dashboard
and scroll all the way to the bottom. Select theReset Options (dev only)
button to make sure your options are clear/wp-admin/index.php
and notice the updatedsite-type
question in the top bannerI build or manage this site for a client
and then selecteContinue
. You should be redirected to the recommendations page and see the newagency
recommendationI build or manage this site for a client
andThis is an e-commerce store
. You should be directed to theagency
recommendation and then thewoocommerce
oneThis is an e-commerce store
and you should be redirected to thewoocommerce recommedation
agency
and thenwoocommerce
recommendations (same as number 1 of this list)monitor
recommendationMake sure you reset your options between every test, the banner question goes away if you have answered it and have not reset them.