Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site type question on wp admin home #26540

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

CodeyGuyDylan
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan commented Sep 29, 2022

A previous PR was created to update the site-type recommendation question, but the banner version of this question was overlooked. This PR edits the banner version to be the same as the one in the assistant

Changes proposed in this Pull Request:

Replace the answers in the site-type question on the banner of wp-admin/index.php. It also updates the slugs behind it so that it can correctly direct users to the right recommendations when redirected to the assistant after answering the question.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

P2: p8oabR-Wd-p2#comment-6607 and pbNhbs-3pg-p2

Does this pull request change what data or activity we track or use?

No it does not

Testing instructions:

  1. Check out this branch and fire up your local environment
  2. Head to /wp-admin/admin.php?page=jetpack#/dashboard and scroll all the way to the bottom. Select the Reset Options (dev only) button to make sure your options are clear
    Screen Shot 2022-09-29 at 2 44 50 PM
  3. Now, head to /wp-admin/index.php and notice the updated site-type question in the top banner
    image
  4. Click on I build or manage this site for a client and then selecte Continue. You should be redirected to the recommendations page and see the new agency recommendation
    image
  5. To test out all scenarios, you can reset your options again and try the following
    • Select I build or manage this site for a client and This is an e-commerce store. You should be directed to the agency recommendation and then the woocommerce one
    • Select only This is an e-commerce store and you should be redirected to the woocommerce recommedation
    • Select all 3 answers, you should get directed to the agency and then woocommerce recommendations (same as number 1 of this list)
    • Select only "This is a personal site", you should see the monitor recommendation

Make sure you reset your options between every test, the banner question goes away if you have answered it and have not reset them.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack update/site-type-question-on-wp-admin-home to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Admin Page React-powered dashboard under the Jetpack menu labels Sep 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: October 4, 2022.
  • Scheduled code freeze: September 27, 2022.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Sep 29, 2022
@CodeyGuyDylan CodeyGuyDylan added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Sep 29, 2022
@CodeyGuyDylan CodeyGuyDylan added this to the jetpack/11.4 milestone Sep 29, 2022
Copy link
Contributor

@robertsreberski robertsreberski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, and test well in all mentioned scenarios!

Copy link
Contributor

@samiff samiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well for me and I was able to see the correct offerings.

@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 29, 2022
@samiff samiff merged commit 023b5f0 into trunk Sep 29, 2022
@samiff samiff deleted the update/site-type-question-on-wp-admin-home branch September 29, 2022 21:51
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 29, 2022
samiff pushed a commit that referenced this pull request Sep 29, 2022
* Update site type question on banner

* Update site-type banner question

* changelog
@samiff
Copy link
Contributor

samiff commented Sep 29, 2022

cherry-picked to jetpack/branch-11.4 in 1f25687

chrisbliss18 pushed a commit that referenced this pull request Sep 30, 2022
* Update site type question on banner

* Update site-type banner question

* changelog
dkmyta pushed a commit that referenced this pull request Oct 1, 2022
* Update site type question on banner

* Update site-type banner question

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants