Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Remove deprecated feature files #34114

Conversation

gmjuhasz
Copy link
Contributor

@gmjuhasz gmjuhasz commented Nov 14, 2023

This change removes the deprecated files from the repo

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/orgs/Automattic/projects/733/views/2?pane=issue&itemId=44049666

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Sanity check that none of the files are used

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the remove/social-deprecated-feature-files branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack remove/social-deprecated-feature-files
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@gmjuhasz gmjuhasz requested a review from a team November 14, 2023 15:02
@gmjuhasz gmjuhasz self-assigned this Nov 14, 2023
@gmjuhasz gmjuhasz marked this pull request as ready for review November 14, 2023 15:25
Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@gmjuhasz gmjuhasz merged commit b5de327 into refactor/social-register-feature-settings Nov 20, 2023
52 of 53 checks passed
@gmjuhasz gmjuhasz deleted the remove/social-deprecated-feature-files branch November 20, 2023 10:58
gmjuhasz added a commit that referenced this pull request Dec 7, 2023
* Add the new settings object + tests

* Update initial states + previous usages

* Update UI + store functions

* changelog

* Fix versions

* Add control for fetching both options together

* Social: Remove deprecated feature files (#34114)

* Remove unneeded files

* changelog

* Social: Refresh store on Publicize module toggle via 1 call (#34142)

* Remove previous refresh functionality

* Add wrapper to refresh settings in class component on Jetpack Settings

* Refresh on social admin page on module toggle change

* Remove useEffect

* Run useEffect only once on module update

* Show toggles instantly on change + only refresh ones on page lifetime

* Update ref logic

* Rename structure

* Fixup versions

* Fix template issue, and make sure it's migrated

* fix tests

* Test fix

* Fix auto-conversion migration logic + add test

* Add auto-conversion sync option

* changelog

* Update versions

* Fix versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants