-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social: Remove deprecated feature files #34114
Social: Remove deprecated feature files #34114
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
b5de327
into
refactor/social-register-feature-settings
* Add the new settings object + tests * Update initial states + previous usages * Update UI + store functions * changelog * Fix versions * Add control for fetching both options together * Social: Remove deprecated feature files (#34114) * Remove unneeded files * changelog * Social: Refresh store on Publicize module toggle via 1 call (#34142) * Remove previous refresh functionality * Add wrapper to refresh settings in class component on Jetpack Settings * Refresh on social admin page on module toggle change * Remove useEffect * Run useEffect only once on module update * Show toggles instantly on change + only refresh ones on page lifetime * Update ref logic * Rename structure * Fixup versions * Fix template issue, and make sure it's migrated * fix tests * Test fix * Fix auto-conversion migration logic + add test * Add auto-conversion sync option * changelog * Update versions * Fix versions
This change removes the deprecated files from the repo
Other information:
Jetpack product discussion
https://github.com/orgs/Automattic/projects/733/views/2?pane=issue&itemId=44049666
Does this pull request change what data or activity we track or use?
No.
Testing instructions: